Add Queue::submit() for command buffer submission#1057
Merged
Conversation
MarijnS95
force-pushed
the
queue-submit
branch
2 times, most recently
from
b77026f to
b8bd9ac
Compare
This comment was marked as resolved.
This comment was marked as resolved.
MarijnS95
force-pushed
the
queue-submit
branch
5 times, most recently
from
5e4f6d2 to
3b4f680
Compare
MarijnS95
force-pushed
the
queue-submit
branch
3 times, most recently
from
0ed7539 to
cfb2665
Compare
MarijnS95
force-pushed
the
queue-submit
branch
4 times, most recently
from
bdd258f to
83e0ad9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
manon-traverse
approved these changes
Apr 17, 2026
This was referenced Apr 17, 2026
MarijnS95
force-pushed
the
queue-submit
branch
2 times, most recently
from
144b44a to
46ba4a6
Compare
bogner
approved these changes
Apr 22, 2026
Comment on lines
+69
to
+71
| llvm::SmallVector<std::unique_ptr<CommandBuffer>> CBs; | ||
| CBs.push_back(std::move(CB)); | ||
| return submit(std::move(CBs)); |
Contributor
There was a problem hiding this comment.
If we do the above, then this SmallVector can have a fixed size of 1, rather than using a bunch of extra stack space here.
Suggested change
| llvm::SmallVector<std::unique_ptr<CommandBuffer>> CBs; | |
| CBs.push_back(std::move(CB)); | |
| return submit(std::move(CBs)); | |
| return submit( | |
| llvm::SmallVector<std::unique_ptr<CommandBuffer>, 1>{std::move(CB)}); |
Collaborator
Author
There was a problem hiding this comment.
Sounds good to explicitly specify the size of N=1. However this move constructor doesn't seem to exist for unique_ptr:
...
include/llvm/ADT/SmallVector.h:1254:11: note: in instantiation of member function
'llvm::SmallVectorImpl<std::unique_ptr<offloadtest::CommandBuffer>>::append' requested here
1254 | this->append(IL);
| ^
include/API/Device.h:70:9: note: in instantiation of member function
'llvm::SmallVector<std::unique_ptr<offloadtest::CommandBuffer>, 1>::SmallVector' requested here
70 | llvm::SmallVector<std::unique_ptr<CommandBuffer>, 1>{std::move(CB)});
| ^
include/c++/15.2.1/bits/unique_ptr.h:524:7: note: 'unique_ptr' has
been explicitly marked deleted here
524 | unique_ptr(const unique_ptr&) = delete;
| ^
a9c9641 to
53209e0
Compare
MarijnS95
force-pushed
the
queue-submit
branch
5 times, most recently
from
a0f8f7b to
5d6df25
Compare
Move command buffer submission logic from each backend's Device into Queue::submit(), which takes ownership of the command buffers. Each backend uses its Fence abstraction for GPU synchronization: - Metal: commit() + waitUntilCompleted() - Vulkan: vkQueueSubmit() signaling a timeline semaphore (VulkanFence), then VulkanFence::waitForCompletion() - DX12: ExecuteCommandLists() + Queue::Signal() on the queue-owned DXFence, then DXFence::waitForCompletion() Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1033Move command buffer submission logic from each backend's
DeviceintoQueue::submit(), which takes ownership of the command buffers. Each backend uses itsFenceabstraction (#1007) for GPU synchronization:commit()+waitUntilCompleted()vkQueueSubmit()signaling a timeline semaphore (VulkanFence), thenVulkanFence::waitForCompletion()ExecuteCommandLists()+Queue::Signal()on the queue-ownedDXFence, thenDXFence::waitForCompletion()Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com